Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clojure] Handle both types of additional properties when getting type declaration #18201

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

njerig
Copy link
Contributor

@njerig njerig commented Mar 22, 2024

Fixes #18199.

PR checklist

  • Read the contribution guidelines.
  • [] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. (No one in Clojure technical committee)

@wing328 wing328 merged commit aedf571 into OpenAPITools:master Mar 23, 2024
14 checks passed
@wing328
Copy link
Member

wing328 commented Mar 23, 2024

lgtm. thanks for the fix

Schema inner = (Schema) p.getAdditionalProperties();

return "(s/map-of string? " + getTypeDeclaration(inner) + ")";
Object additionalProperties = p.getAdditionalProperties();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've filed #18212 to rename the variable to just ap as the generator itself also has a property/field named "additionalProperties"

@wing328
Copy link
Member

wing328 commented Mar 23, 2024

fyi. filed #18212 to fix the issue in other generators as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CLOJURE] Clojure fails with java.lang.ClassCastException
2 participants