Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Naming Strategy" to "Naming Convention" #56

Closed
JFCote opened this issue Dec 9, 2019 · 2 comments · Fixed by #61
Closed

Change "Naming Strategy" to "Naming Convention" #56

JFCote opened this issue Dec 9, 2019 · 2 comments · Fixed by #61
Assignees

Comments

@JFCote
Copy link
Member

JFCote commented Dec 9, 2019

Very important to stay backward compatible for a while. Maybe add a warning log when people use the old one and say it will be deleted in a future version.

@jmini
Copy link
Member

jmini commented Dec 16, 2019

With the same move, I suggest to rename appelation to designation:

private final String appelation;
NamingStrategy(String appelation) {
this.appelation = appelation;
}
public String getAppelation() {
return appelation;
}

Of course only in the new enum NamingConvention.

@JFCote
Copy link
Member Author

JFCote commented Dec 16, 2019

@jmini That make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants