Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Local development record, replay and start fail #773

Open
shashank40 opened this issue Jun 18, 2024 · 3 comments
Open

[Bug]: Local development record, replay and start fail #773

shashank40 opened this issue Jun 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@shashank40
Copy link
Contributor

Describe the bug

So the current local development setup is buggy due to recent code changes. The helper function definitions were changed but the usage was not updates.
Ex: functions for recording start, replay etc

To Reproduce

Any record start will fail

@shashank40 shashank40 added the bug Something isn't working label Jun 18, 2024
@shashank40
Copy link
Contributor Author

shashank40 commented Jun 18, 2024

@abrichr would you mind if i raise a PR on this?

@abrichr
Copy link
Contributor

abrichr commented Jun 18, 2024

@shashank40 thank you for reporting! Please try #774 and see if that fixes your issues.

Otherwise please submit a PR 🙏

@shashank40
Copy link
Contributor Author

@abrichr it has a few more things to update.

  1. During instruction submissions on replay, it fails.
  2. During data fetch from DB, it fails as session was not passed.
  3. During start, the code fails as the function imported is not found in start.py

I will raise a quick PR, i think this could be the reason why even downloaded openadapt app is not working as i mentioned here.

#771 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants