Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit to proxy #12

Merged
merged 1 commit into from
Oct 24, 2014
Merged

Submit to proxy #12

merged 1 commit into from
Oct 24, 2014

Conversation

pezholio
Copy link
Member

This now submits addresses to https://github.com/OpenAddressesUK/address-capture, to capture the IP address and user agent of the submitter. Once the actual form proper has been set up with the relevant fields (address, ip address and user agent), I'll need the URL and the input field names (in the actual HTML) to add to the app.

Also, it might be worth CNAMEing the adress capture app (something like submit.openaddressesuk.org), so it doesn't look like you're just submitting to a random Heroku app.

@pikesley
Copy link
Member

Are there Data Protection implications if we start snaffling IP addresses?

@pezholio
Copy link
Member Author

There's going to be some Ts&Cs added which will cover this I think (see https://docs.google.com/a/theodi.org/document/d/1k1HBJ_dCMpfhKPGGPMq4yrq2MbjaW9hwbG4NFGIiq_M/edit)

@peterkwells
Copy link

re: DPA The text in the linked Google doc has been checked against/with the legal advice. Also see the Privacy Policy linked from the footer of the site.

I've never created a Google form but doesn't look difficult. Is that in hand or should I do it?

@pezholio
Copy link
Member Author

@peterkwells - If you can set up a spreadsheet in the relevant place in the OA GDocs drive and let me know where it is, I can take it from there 👍

@peterkwells
Copy link

@pezholio spreadsheet here: https://docs.google.com/a/openaddress.es/spreadsheets/d/1a5qV5poR669NMZIv2GCS9lzGeYn0x8CDjWyF5DwVBSo/edit?usp=sharing

Three columns: Timestamp, IPAddress, SubmittedAddress. Feel free to flip them around.

UA has been dropped from the reqs.

@pezholio
Copy link
Member Author

@peterkwells Can I have edit access please?

@peterkwells
Copy link

@pezholio invite should be on its way. If it's the wrong link then give me a call on 07920272991 and help me press the right one ;-)

@pezholio
Copy link
Member Author

Just tested it and it works perfectly 👍

Floppy added a commit that referenced this pull request Oct 24, 2014
@Floppy Floppy merged commit 4a62ae1 into master Oct 24, 2014
@Floppy Floppy deleted the feature-submit-addresses-to-proxy branch October 24, 2014 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants