Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

CORS removed #39

Merged
merged 2 commits into from Sep 19, 2016
Merged

Conversation

yaromins
Copy link
Contributor

Based on this discussion openag_brain api is supposed to be run through CouchDb proxy which already has CORS enabled. So this one has to be removed to avoid error with multiple values set

The 'Access-Control-Allow-Origin' header contains multiple values 'http://localhost, http://localhost', but only one is allowed

Based on [this discussion](at OpenAgricultureFoundation/openag_brain_docker_rpi#12) openag_brain api is supposed to be run through CouchDb proxy which already has CORS enabled. So this one has to be removed to avoid error with multiple values set 
>The 'Access-Control-Allow-Origin' header contains multiple values 'http://localhost, http://localhost', but only one is allowed
@gordonbrander
Copy link
Contributor

gordonbrander commented Sep 12, 2016

@serein7 Thanks for catching this! We also need to remove the flask-cors dependency, if it is no longer needed https://github.com/OpenAgInitiative/openag_brain/blob/master/package.xml#L54.

@gordonbrander
Copy link
Contributor

@serein7 can you also remove the flask CORS dependency in this patch (see link above)? Or if you don't want to, I can fork the patch and do it.

@yaromins
Copy link
Contributor Author

OK. I'll do later today

On Thu, Sep 15, 2016, 6:38 PM Gordon Brander notifications@github.com
wrote:

@serein7 https://github.com/serein7 can you also remove the flask CORS
dependency in this patch (see link above)? Or if you don't want to, I can
fork the patch and do it.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#39 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABePyX-PL8vz3qgLv2NLHq98L08EaQJDks5qqWZXgaJpZM4J5-Mx
.

@yaromins
Copy link
Contributor Author

@gordonbrander, removed

Copy link
Contributor

@gordonbrander gordonbrander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

@gordonbrander gordonbrander merged commit 6437628 into OpenAgricultureFoundation:master Sep 19, 2016
@yaromins yaromins deleted the patch-1 branch September 19, 2016 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants