-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch MC to using openassetio-traitgen
#10
Comments
This was referenced Nov 1, 2022
openassetio-traitgen
openassetio-traitgen
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Nov 25, 2022
Rather than have manually maintained traits, integrate traitgen to generate the traits automatically in the build. Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Nov 25, 2022
Add import tests to mediacreation, to check that the generated traits function. Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Nov 25, 2022
Run pytest on PRs, so we can have some CI going. Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Nov 25, 2022
Remove the tests that were testing the manually rolled traits. Now that the traits are autogenerated, we rely on the tests in openassetio-traitgen Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Dec 1, 2022
Rather than have manually maintained traits, integrate traitgen to generate the traits automatically in the build. Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Dec 1, 2022
Add import tests to mediacreation, to check that the generated traits function. Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Dec 1, 2022
Run pytest on PRs, so we can have some CI going. Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
elliotcmorris
referenced
this issue
in elliotcmorris/OpenAssetIO-MediaCreation
Dec 1, 2022
Remove the tests that were testing the manually rolled traits. Now that the traits are autogenerated, we rely on the tests in openassetio-traitgen Issue #10 Signed-off-by: Elliot Morris <elliot.morris@foundry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Once
openassetio-traitgen
is available in PyPI, convert the traits in the repo to.yml
definitions, and build withopenassetio-traitgen
as part ofsetup.py
.Why
Manual authoring of Trait/Specification code is deprecated as it is prohibitively slow.
Notes
Requires OpenAssetIO/OpenAssetIO-TraitGen#2
We currently have the strategy that we "trust" traitgen code through its own testing, so there isn't need to write extensive tests for autogenerated classes.
It's to be expected that the resulting Python namespace will change.
Be good to hard code the yaml hints to the JSON schema in github for traitgen.
Timeline
,Track
andClip
traits -> atimeline
namespaceLoatableContent
-> acontent
namespace(?)ACs
python -m pip install .
installs an importableopenassetio_mediacreation
module in Python 3.7+yaml
.The text was updated successfully, but these errors were encountered: