Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add equality comparison operator to BatchElementError #862

Closed
feltech opened this issue Mar 28, 2023 · 2 comments · Fixed by #881
Closed

[Core] Add equality comparison operator to BatchElementError #862

feltech opened this issue Mar 28, 2023 · 2 comments · Fixed by #881
Assignees

Comments

@feltech
Copy link
Member

feltech commented Mar 28, 2023

What

Add equality operator to BatchElementError.

Why

This would be useful for tests, if nothing else.

ACs

  • Given two different error objects (with different addresses) error1 == error2
  • No temp comparison implementations remain in tests/etc
  • Tests that compare BEEs (🐝) updated.
  • != behaviour also tested if required but not if inherent in the language (C++/Python, create issue for TraitsData if were missing anything there)

Notes

Implement as member function to follow prior art

@foundrytom
Copy link
Collaborator

Remember to update ManagerTest.cpp

@foundrytom
Copy link
Collaborator

... and test_manager.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants