Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant DB access for ACL #441

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove redundant DB access for ACL #441

wants to merge 3 commits into from

Conversation

zhugelianglongming
Copy link
Collaborator

@zhugelianglongming zhugelianglongming commented Feb 22, 2023 •
edited
Loading

  1. Remove redundant DB access for ACL
  2. Improve performance
  3. Improve readability
  4. Refactor code style: Procedural-Oriented -> Object-Oriented
  5. Improve code coverage

Fix #435

@codecov-commenter
Copy link

Codecov Report

Merging #441 (719cb03) into master (af39eb9) will increase coverage by 0.27%.
The diff coverage is 82.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   45.06%   45.34%   +0.27%     
==========================================
  Files         145      151       +6     
  Lines       12996    13205     +209     
==========================================
+ Hits         5857     5988     +131     
- Misses       5955     6026      +71     
- Partials     1184     1191       +7
Impacted Files Coverage Δ
kernel/permission/acl/utils/def.go 16.66% <0.00%> (ø)
kernel/permission/acl/acl.go 63.15% <63.15%> (ø)
kernel/permission/acl/contract.go 91.20% <93.75%> (ø)
kernel/permission/acl/bucket/account.go 100.00% <100.00%> (ø)
kernel/permission/acl/bucket/ak_2_account.go 100.00% <100.00%> (ø)
kernel/permission/acl/bucket/contract.go 100.00% <100.00%> (ø)
bcs/consensus/xpoa/xpoa.go 51.26% <0.00%> (-1.02%) ⬇️
bcs/ledger/xledger/tx/mempool.go 42.06% <0.00%> (-0.28%) ⬇️
kernel/permission/acl/manager.go 0.00% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoweibupt gaoweibupt Awaiting requested review from gaoweibupt

@godeamon godeamon Awaiting requested review from godeamon

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix kernel/permission/acl
2 participants
@zhugelianglongming @codecov-commenter