Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] /econometrics/export - cannot set filename, only the type. #5476

Closed
deeleeramone opened this issue Sep 25, 2023 · 2 comments · Fixed by #5508
Closed

[Bug] /econometrics/export - cannot set filename, only the type. #5476

deeleeramone opened this issue Sep 25, 2023 · 2 comments · Fixed by #5508
Assignees
Labels
bug Fix bug HACKTOBERFEST Hacktoberfest

Comments

@deeleeramone
Copy link
Contributor

If you attempt to export from the /econometrics menu, the filename cannot be deliberately set. You get "invalid choice".

@deeleeramone deeleeramone added the bug Fix bug label Sep 25, 2023
@ssahaxd
Copy link
Contributor

ssahaxd commented Oct 2, 2023

Hi, I can fix this.
Need help with passing the pre-commit checks. the following checks are failing.

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

openbb_terminal/core/models/user_model.py:15: error: Variable "openbb_terminal.core.models.credentials_model.CredentialsModel" is not valid as a type  [valid-type]
openbb_terminal/core/models/user_model.py:15: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
openbb_terminal/core/plots/backend.py:361: error: Signature of "start" incompatible with supertype "PyWry"  [override]
openbb_terminal/core/plots/backend.py:361: note:      Superclass:
openbb_terminal/core/plots/backend.py:361: note:          def start(self, debug: bool = ..., headless: bool = ...) -> Any
openbb_terminal/core/plots/backend.py:361: note:      Subclass:
openbb_terminal/core/plots/backend.py:361: note:          def start(self, debug: bool = ...) -> Any
Found 2 errors in 2 files (checked 1 source file)

Strip notebooks output...............................(no files to check)Skipped
pylint...................................................................Failed
- hook id: pylint
- exit code: 2

************* Module openbb_terminal.stocks.fundamental_analysis.av_model
openbb_terminal/stocks/fundamental_analysis/av_model.py 727: E1101 Method 'index' has no 'equals' member (no-member)
************* Module openbb_terminal.stocks.options.tradier_model
openbb_terminal/stocks/options/tradier_model.py 396: E1137 'underlying_price' does not support item assignment (unsupported-assignment-operation)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Detect secrets...........................................................Passed
Check validity of reserved arguments.....................................Failed
- hook id: reserved_args
- exit code: 1

/home/sandip/Desktop/hacktoberfest/OpenBBTerminal/openbb_terminal/stocks/fundamental_analysis/fa_controller.py: '-f' argument expected 'file' but assigned to 'form'
/home/sandip/Desktop/hacktoberfest/OpenBBTerminal/openbb_terminal/stocks/technical_analysis/ta_controller.py: '-f' argument expected 'file' but assigned to 'forward'

@deeleeramone
Copy link
Contributor Author

Hi, I can fix this. Need help with passing the pre-commit checks. the following checks are failing.

Howdy! Nice inadvertent find, I've got a patch for that in #5506, to for now, you can try --no-verify. That will skip the unit tests too, locally, but that'll get you into a commit.

@deeleeramone deeleeramone added the HACKTOBERFEST Hacktoberfest label Oct 11, 2023
@deeleeramone deeleeramone linked a pull request Oct 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug HACKTOBERFEST Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants