Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal authentication + keys/settings/routines #4015

Merged
merged 261 commits into from
Feb 9, 2023
Merged

Terminal authentication + keys/settings/routines #4015

merged 261 commits into from
Feb 9, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Jan 19, 2023 •
edited
Loading

Description

Screenshot 2023-02-06 at 10 28 02

image

TODO:

  • Allow timezone auto upload
  • Allow userdata auto upload
  • Invalidate remote session on logout
  • Write unit tests
  • Add timeout to requests

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Jan 19, 2023
reviewpad[bot]
reviewpad bot previously requested changes Jan 19, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency tree has been changed. Please update requirements.txt and requirements-full.txt

@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Jan 19, 2023
@hjoaquim hjoaquim mentioned this pull request Feb 7, 2023
Closed
@montezdesousa montezdesousa mentioned this pull request Feb 8, 2023
Closed
montezdesousa and others added 8 commits February 8, 2023 11:41
@montezdesousa
Merge branch 'develop' into feature/login
026ec53
@montezdesousa
ruff
b9bc0aa
@montezdesousa
fix sources not updated real time
269c339
@montezdesousa
Merge branch 'develop' into feature/login
d593f99
@montezdesousa
missing return doc
555dae0
@montezdesousa
Merge branch 'feature/login' of github.com:OpenBB-finance/OpenBBTermi…
68cd7e3 
…nal into feature/login
@montezdesousa
add guest if no email
759a2c7
@montezdesousa
Routine remote storage (#4143)
ead2e2e 
* add upload routine command

* remove prints

* point to local again

* add commands

* add delete

* add download command and upload 409

* list comprehension

* add download & save plus upload fixe

* add user uuid folder

* add list command

* ruff

* en.yml detail

* provide choices to delete & download

* add choices to upload

* change menu text

* starting adding unit tests

* bad english

* Update test_print_help.txt

* genearl msgs

* remove print

* add docstrings

* add unit tests to account controller

* change parser

* fix routine upload test

* add to be implemented tests hub

* add to be implemented tests local

* add total pages to title

* split list into model and view

* add docstring

* print msg if character

* add local model tests

* hub tests routines

* fix test

* point to dev and glob

* fix small bug on upload

* missing return

* log decorators missing

* black

* ruff
@montezdesousa montezdesousa changed the title Terminal authentication + keys/settings Terminal authentication + keys/settings/routines Feb 9, 2023
Chavithra
Chavithra approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

@montezdesousa montezdesousa merged commit 5953be0 into develop Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@reviewpad reviewpad[bot] reviewpad left review comments

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

@jmaslek jmaslek Awaiting requested review from jmaslek

@colin99d colin99d Awaiting requested review from colin99d

Assignees
No one assigned
Labels
feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] settings/source - does not accept changes because of / in paths.
4 participants
@montezdesousa @Chavithra @hjoaquim @jmaslek