Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR Template and Contributing guidelines #4194

Merged
merged 8 commits into from
Feb 10, 2023
Merged

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Feb 9, 2023

Also undo the merge group

@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Feb 9, 2023
@@ -19,10 +19,11 @@

# Checklist:

- [ ] Update [our Hugo documentation](https://openbb-finance.github.io/OpenBBTerminal/) following [these guidelines](https://github.com/OpenBB-finance/OpenBBTerminal/tree/main/website).
- [ ] I have adhered to the GitFlow naming convention and my branch name is in the format of `feature/feature-name` or `bugfix/bugfix-name`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it hotfix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed supposed to be

@jmaslek jmaslek merged commit 92360a7 into develop Feb 10, 2023
@jmaslek jmaslek deleted the feature/updates branch February 15, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants