Feature/general improvements #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
feat XL
hjoaquim
approved these changes
Feb 13, 2023
| @@ -106,7 +107,6 @@ def print_help(self): | |||
| mt.add_cmd("load") | |||
| mt.add_raw("\n") | |||
| mt.add_param("_ticker", stock_text) | |||
| mt.add_raw(self.add_info) | |||
| mt.add_raw("\n") | |||
| mt.add_cmd("quote", self.ticker) | |||
There was a problem hiding this comment.
Regarding quote, tob, candle, codes, news, if those are usable upon --ticker arg, shouldn't they be blueish? Also, why exclude candle and news?
There was a problem hiding this comment.
Yes and I forgot them :(
jmaslek
force-pushed
the
feature/general-improvements
branch
from
d6b3263
to
9ff474e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly allows users to enter any stocks submenu without doing load first (except for research).
Within the fa menu, this adds ticker arguments to all functions, ie (cash -t aapl) instead of load appl/cash.