Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Migrate user, feature flags and configurations to dataclass #4309

Merged
merged 156 commits into from
Mar 4, 2023
Merged

[WIP] Migrate user, feature flags and configurations to dataclass #4309

merged 156 commits into from
Mar 4, 2023

Conversation

montezdesousa
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the account Authentication features label Feb 20, 2023
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Feb 20, 2023
@montezdesousa montezdesousa changed the title Migrate user.py Migrate user.py to dataclass Feb 20, 2023
@montezdesousa montezdesousa marked this pull request as ready for review February 20, 2023 20:27
hjoaquim
hjoaquim approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very cool addition, functionality is kept both on the SDK and the Terminal.
Simple implementation yet powerful. Eager to see how credentials, preferences and configurations will play.

This will potentially conflict with #4297 and #4299 - so it's probably better to merge this one 1st and then do the necessary adjustments to the other PRs.

openbb_terminal/core/models/profile.py Outdated Show resolved Hide resolved
@montezdesousa montezdesousa changed the title Migrate user.py to dataclass [WIP] Migrate user.py to dataclass Feb 22, 2023
@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label Feb 22, 2023
@montezdesousa
Copy link
Contributor Author

This is a very cool addition, functionality is kept both on the SDK and the Terminal. Simple implementation yet powerful. Eager to see how credentials, preferences and configurations will play.

This will potentially conflict with #4297 and #4299 - so it's probably better to merge this one 1st and then do the necessary adjustments to the other PRs.

Tks for the review, I'm reassessing if this version is good enough so don't be blocked by this. I can solve conflicts here afterwards

auto-merge was automatically disabled March 1, 2023 16:50

Merge queue setting changed

@Chavithra Chavithra merged commit 475ebb5 into develop Mar 4, 2023
@Chavithra Chavithra deleted the feature/user_class branch March 4, 2023 23:37
@tehcoderer tehcoderer mentioned this pull request Mar 6, 2023
Merged
15 tasks
jmaslek added a commit that referenced this pull request Apr 13, 2023
@montezdesousa @Chavithra
@luqmanbello @jmaslek
[WIP] Migrate user, feature flags and configurations to dataclass (#4309
c0563f0 
)

* implement user and change is guest

* replace User methods

* move remaining functions to user

* fix bug

* portfolio test

* fix tests

* fix tests

* uncomment skip

* ruff

* start credentials model implementation

* change deault structure

* refacto quandl

* change default struct and file names

* bug

* start using global user

* add comments

* move update flair

* change cfg references in keys model

* reddit & fmp

* refactore additional keys

* remaing config keys

* remove unsude imports and fix hub keys

* ruff

* fix line too long

* unblock unittests

* fix keys model tests

* remove os patch

* fix account controller tests

* fix account controller tests

* fix account model

* account fixed

* fix user tests

* User Model

* User Model

* User Model

* Move session folder

* User Model : grouping the models

* User Model : fix bugs

* Config Plot + bug fix

* User Model : Refactoring plots

* Feature flags

* Remove dup

* clean comments a fix some vars

* fix feature flags controller

* refactor obbff from settings controller

* refactor a bunch of obbff variables

* fix bug blocking terminal

* fix integration tests

* refactor controllers with obbff

* refactor remaining ffs

* remove comments

* log not started

* mispelled variable

* set current user on local model

* User Model : moving files + updating

* User Preferences

* User : Refactor is_guest function + bug fix

* User : refactor is_guest function

* Fix conftest.py

* remove lost obbffs

* typo on fileoverwrite

* Plot config: move variables and start plot dpi

* User : tests

* refactor plot dpi references

* remove plot dpi imports

* refactor some config terminal leftover

* /account/sync : fix bug

* remove configs reload

* start path refactor

* installation paths vs user paths

* remove cfg_plot

* Tests : User Refactoring

* user prefix only for preferences

* user prefix only for preferences

* move user paths

* remove comment

* update apply remote configs

* fix tz not updating

* save some copys

* small fix

* create interface for credentials and preferences

* wrong docstrings fixed

* ruff core

* fix some pref setting

* login is better

* ruff

* ruff

* remove Literal

* add small comment

* Tests : User Refactoring

* Credentials Model : add DataBento

* Fix helper_funcs

* Fixing code

* Tests : fixing

* User Model : freezing the models

* Fixed Income + Databento

* Tests : fixing keys

* black

* ruff

* Tests : user model

* Tests : user model

* Fix linting

* Fix linting

* Linting

* Linting

* Fixing code and tests

* Fix tests

* mypy

* SDK

* Clean ruff cache

* Fix syntax issue

* Update fred_view

* Black

* Linting

* Update code

* Update tests

* Linting

* Linting

* Tests

* Black

* Linting

* Linting

* Mock os.listdir to avoid looking for file that doesnt exist

* Mock options paths

* lint

* Tests : fix

* Code : update

* Tests + Linting

* Tests

* Ruff

* Code : update

* Tests

* Code : update

* Fix workflow

* Code : update

---------

Co-authored-by: Chavithra PARANA <chavithra@gmail.com>
Co-authored-by: luqazino@gmail.com <luqazino@gmail.com>
Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
account Authentication features feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] New tweet functionality breaks loading the terminal
5 participants
@montezdesousa @Chavithra @hjoaquim @luqmanbello @jmaslek