Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/news sentiment #5274

Merged
merged 59 commits into from
Aug 8, 2023
Merged

Conversation

Sai-132
Copy link
Contributor

@Sai-132 Sai-132 commented Aug 2, 2023

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

SaiKollipaka and others added 30 commits February 24, 2023 17:36
@reviewpad reviewpad bot added the feat XS Extra small feature label Aug 2, 2023
@Sai-132
Copy link
Contributor Author

Sai-132 commented Aug 2, 2023

I wanted to inform you that I have made the necessary updates to the code as part of our domain name change. Kindly review the changes and let me know your feedback.

@jmaslek
Copy link
Collaborator

jmaslek commented Aug 3, 2023

Your entry in the trail map is a duplicate and is what causes the failed test

@Sai-132
Copy link
Contributor Author

Sai-132 commented Aug 4, 2023

Your entry in the trail map is a duplicate and is what causes the failed test

I understand your concern, and upon reviewing my last commit, I see that only one file was edited, and it was not the 'trail map' file. I haven't updated the 'trail map' file yet. There may be a different reason for the failed test and duplicate entry.

@jmaslek
Copy link
Collaborator

jmaslek commented Aug 4, 2023

Your entry in the trail map is a duplicate and is what causes the failed test

I understand your concern, and upon reviewing my last commit, I see that only one file was edited, and it was not the 'trail map' file. I haven't updated the 'trail map' file yet. There may be a different reason for the failed test and duplicate entry.

Screenshot 2023-08-04 at 2 17 33 PM

@Sai-132
Copy link
Contributor Author

Sai-132 commented Aug 8, 2023

I've made the necessary updates to the Trail map file.

@jmaslek jmaslek added this pull request to the merge queue Aug 8, 2023
Merged via the queue into OpenBB-finance:develop with commit 1523f3f Aug 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants