Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print message if yahoo finance load fails #5450

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Light-JH
Copy link
Contributor

Fixes #5392

Currently, in the /stocks/load command, if yahoo finance does not find data it doesn't print any indication to the user.

This PR adds a message if yahoo finance does not find data:

Screenshot 2023-09-19 at 2 43 11 PM

@reviewpad reviewpad bot added the feat XS Extra small feature label Sep 20, 2023
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @Light-JH 🚀

@piiq piiq added this pull request to the merge queue Sep 20, 2023
Merged via the queue into OpenBB-finance:develop with commit 78ebeef Sep 20, 2023
13 of 14 checks passed
@Light-JH Light-JH deleted the hotfix/load_yf_silent_failure branch September 21, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
2 participants