Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/econometrics export filename fix #5508

Merged
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions openbb_terminal/econometrics/econometrics_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,15 @@ def call_export(self, other_args: List[str]):
type=str,
)

parser.add_argument(
export_group = parser.add_mutually_exclusive_group(required=False)
export_group.add_argument(
"-f",
ssahaxd marked this conversation as resolved.
Show resolved Hide resolved
"--file",
dest="file",
help="The name of the file you wish to export to",
type=str,
)
export_group.add_argument(
"-t",
"--type",
help="The file type you wish to export to",
Expand All @@ -471,18 +479,19 @@ def call_export(self, other_args: List[str]):
if other_args and "-" not in other_args[0][0]:
other_args.insert(0, "-n")
ns_parser = self.parse_known_args_and_warn(
parser, other_args, export_allowed=NO_EXPORT
parser, other_args, export_allowed=EXPORT_ONLY_RAW_DATA_ALLOWED
)

if ns_parser:
if not ns_parser.name or ns_parser.name not in self.datasets:
console.print("Please enter a valid dataset.")
deeleeramone marked this conversation as resolved.
Show resolved Hide resolved
else:
export_data(
ns_parser.type,
ns_parser.file if ns_parser.file else ns_parser.type,
os.path.dirname(os.path.abspath(__file__)),
ns_parser.name,
self.datasets[ns_parser.name],
deeleeramone marked this conversation as resolved.
Show resolved Hide resolved
sheet_name=" ".join(ns_parser.sheet_name) if ns_parser.sheet_name else None,
)

console.print()
Expand Down
Loading