Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] AV Historical EPS - Expose Error Message On Request Fail #6406

Merged
merged 3 commits into from
May 14, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • The error message was not being returned when the request failed.
  2. What?:

    • Tracks the messages and raises if no results are returned for all symbols.
  3. Impact:

    • Adds clarity to the response.
  4. Testing Done:

OpenBBError: No data was returned -> 
Thank you for using Alpha Vantage! Our standard API rate limit is 25 requests per day. Please subscribe to any of the premium plans at https://www.alphavantage.co/premium/ to instantly remove all daily rate limits.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels May 13, 2024
@IgorWounds IgorWounds enabled auto-merge May 14, 2024 08:10
@IgorWounds IgorWounds added this pull request to the merge queue May 14, 2024
Merged via the queue into develop with commit 29dfc7b May 14, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/av-historical-eps-error-message branch May 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants