Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Logging start / stop #400

Closed
jps2000 opened this issue Nov 9, 2018 · 18 comments
Closed

Data Logging start / stop #400

jps2000 opened this issue Nov 9, 2018 · 18 comments

Comments

@jps2000
Copy link

jps2000 commented Nov 9, 2018

Problem

Data logging start works as expected. Data logging stop does not. One need to stop system that a file is written and closed. This is similar to #2 but not solved by #38 etc. Files of several hours recording are not easy to handle in playback ( take very long to open etc)

Expected

I would expect to stop a recording and write the file as soon as stop is pressed. This allow preventing long recordings that can not (hardly) be playback.
Ideally there is a pause function as well (Start continue recording in same file) but that is nice to have

Operating System and Version

W7 professional

GUI Version

4.0.2

Running standalone app

downloaded app

Type of OpenBCI Board

Ganglion

Are you using a WiFi Shield?

No

@retiutut
Copy link
Member

retiutut commented Nov 9, 2018

Looking into this...

@retiutut
Copy link
Member

retiutut commented Nov 13, 2018

@jps2000 Thank you for making an issue for this! Let's discuss the features you would like added.

Currently we can Start/Pause using the "Start/Stop Data Stream" button. As you explained, we need a way to completely stop a recording and save the log file without stopping the system.

I propose the following solution:

  • Add a Save Log File button to Live mode for Ganglion/Cyton
  • Save Log File Button will write file and prompt user to select new log file info, just like the system control panel

@jps2000
Copy link
Author

jps2000 commented Nov 13, 2018

start stop data stream making start pause is fine. Pressing stop in the network screen should stop recording and save the log file. data stream may continue. pressing start again should start with new log file.
So second proposal is fine. No new button is needed.
Start / Stop button in networking has toggle behavior. However, only first start press leads to action . Stop has no effect?

@retiutut
Copy link
Member

That button is for networking only. This issue involves file operations.

@jps2000
Copy link
Author

jps2000 commented Nov 13, 2018

I do not understand "networking only" but I am happy with any improvement that is self explaining

@retiutut
Copy link
Member

Or maybe call it a "Save Log File" button? I made a picture to help clarify what I propose.
openbci-2018-11-13_12-00-19 - new save log file button proposal

@jps2000
Copy link
Author

jps2000 commented Nov 13, 2018

what is start stop networking doing?
When I select time series for example in stream 1 then start networking starts log file now. Button turns to red and is called Stop. Pressing Stop however has no effect.
That is what I understand now.
I suggest that stop close the log file.
Is this contradiction to something?
Do you need a start/ stop button for every stream as alternative?

@jps2000
Copy link
Author

jps2000 commented Nov 13, 2018

New file name can include actual time stamp

@retiutut
Copy link
Member

Start/Stop Network stream has nothing to do with the log file!

@jps2000
Copy link
Author

jps2000 commented Nov 13, 2018

But what is it doing?
when does the logfile start now?

@retiutut
Copy link
Member

retiutut commented Nov 13, 2018

In the Networking Widget, the Start/Stop Networking button allows you to send data to another program (example: send to Max using the OSC protocol).

Currently, the log file starts recording to file when you press "Start Data Stream", and pauses when you press "Stop Data Stream".

I will get started on this!!! 🎉 🎉 🎉

@jps2000
Copy link
Author

jps2000 commented Nov 13, 2018

Will re- check tomorrow (ganglion). That is not according to my experience but I may be wrong....
I used to select time series in stream 1 and pressed start after start data stream. So you are saying thats useless.

I want to start/ stop datastream ( to verify what is coming) and start/stop logfile on top of. The latter should work only when data stream is running. It would be even better when stop datastream is only allowed once logfile has stopped.

Anyhow... make something that is understandable for IQ 100 guys.

First time I heard from an OSC protocol....

@jps2000
Copy link
Author

jps2000 commented Nov 14, 2018

Have tested it and of course you are right. I interpreted the networking widget as universal I/O tool that also includes log file writing.

@andrewjaykeller
Copy link

@conorrussomanno what do you think?

@retiutut
Copy link
Member

retiutut commented Dec 16, 2018

This seems related: #30

@jps2000
Copy link
Author

jps2000 commented Feb 23, 2019

From #443 :
For example sleep studies etc need analysis of recordings in the magnitude of hours.
Such long files can not be handled now.
A remedy may be a recording scheduler to limit length of recordings.
(start a new recording (file) after x minutes)

@jps2000 jps2000 closed this as completed Mar 15, 2019
OpenBCI SW Dev automation moved this from To do to Done Mar 15, 2019
@retiutut
Copy link
Member

Sorry for the delay on this issue.

For example sleep studies etc need analysis of recordings in the magnitude of hours.
Such long files can not be handled now.
A remedy may be a recording scheduler to limit length of recordings.
(start a new recording (file) after x minutes)

@jps2000 Are you sure this needs to be closed?

Or maybe rename it to "Add support for longer recordings in GUI"?

@jps2000
Copy link
Author

jps2000 commented Mar 19, 2019

I´d better open a new one on that
#461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants