Search within Pages

[drwasho]

For tracking purposes.

We have a search bar for various pages that is yet to be wired up. We can track progress here and close the issue once it's done.

Discover Page

• Search listings
• Search pages

Chat

• Search messages defer for v1.1

User Page

• Search user page listings on store tab
• Search followers/following list

Orders Page

• Search purchases
• Search sales
• Search cases

[jjeffryes]

Are the two bullet points for searching chat and searching messages both referring to the same thing?

[drwasho]

Fixed.

[rmisio]

The two User Page bullet points are complete and ready for QA.

[jjeffryes]

For clarification, what should search messages in chat do?

Currently, the get_chat_conversations API doesn't return anything that can be searched against, other than guid.

Does the search filter the conversation you're looking at?

[hoffmabc]

I thought I already implemented the search for chat which is just by GUID.

[jjeffryes]

Right, is it listed here because there should be more to search by than guid?

[hoffmabc]

I mean it would be nice if we could search conversations but that's not a 1.0. Should probably just consider this completed and defer full search until later.

[morebrownies]

[drwasho]

Happy to see 'search by conversation' bounce to post-v1.

Search by handle to find an open conversation would be great for v1, but probably a stretch goal.

[drwasho]

Searching a store page doesn't seem to be working. Can someone confirm?

[jjeffryes]

It's working normally for me in the master branch.

[drwasho]

I'm on master, and I can't search for any keywords when I go to a store page; Discover tab is working just fine for search.

[SamPatt]

I'm closing, @morebrownies or @jjeffryes feel free to re-open if it's premature.

[drwasho]

Thanks Sam!