Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Improve the design of the call-out to select a default search provider #1600

Open
rmisio opened this issue Nov 5, 2018 · 1 comment
Open
Assignees
Labels
low priority cosmetic or non-blocking

Comments

@rmisio
Copy link
Contributor

rmisio commented Nov 5, 2018

image

The design IMHO just looks "broken". It looks odd that the triangle area points between the first and the second item. The first thought is always that it should be pointing to an actual item and we've even had a bug logged about that. I understand that the idea is for it not to point to an item, but rather to the group, since you need to select an item. But... there's just got to be a better way to reflect that.

@rmisio rmisio added the low priority cosmetic or non-blocking label Nov 5, 2018
@jjeffryes
Copy link
Contributor

jjeffryes commented Nov 16, 2018

Something that came up in discussion:

It might be better to start with no search providers, and give the user a modal that lists the defaults, with a short description of each, and allow them to add them. They could make one of them the default while doing that, or if they just add one it's automatically the default.

This would let us include a message saying we can't vouch for the content on 3rd party providers, and the user would have to make a conscious choice to add providers that may have content we don't vouch for, vs. 3rd party providers being added by default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
low priority cosmetic or non-blocking
Projects
None yet
Development

No branches or pull requests

3 participants