(ETH) Unable to resolve dispute due to absence of vendor contract

[drwasho]

This is expected behaviour, but we should really consider removing this as sometimes there are errors in either delivering the vendor contrac to the moderator or the data is received by the moderator but incorrectly processed, leading to an unrecoverable state.

This is what I managed to glean from the logs:

2020-02-27 21:47:56.383 [DEBUG] [core/SendProcessingError] sending ORDER_PROCESSING_ERROR to peer (QmRGCvxohRX7NtAHJ2vziW6DTitCDJxSsJ3QG7GsJeLgpi)
2020-02-27 21:47:56.383 [DEBUG] [service/SendMessage] Sending ORDER_PROCESSING_FAILURE message to QmRGCvxohRX7NtAHJ2vziW6DTitCDJxSsJ3QG7GsJeLgpi
2020-02-27 21:47:56.383 [DEBUG] [service/messageSenderForPeer] Found existing message sender for: QmRGCvxohRX7NtAHJ2vziW6DTitCDJxSsJ3QG7GsJeLgpi
2020-02-27 21:47:56.383 [DEBUG] [service/handleNewMessage] DISPUTE_UPDATE handle message error from QmRGCvxohRX7NtAHJ2vziW6DTitCDJxSsJ3QG7GsJeLgpi: message arrived out of order
2020-02-27 21:47:56.638 [DEBUG] [service/handleDisputeOpen] received DISPUTE_OPEN message from QmW1fE8BeHQGup7gaNLXx2gM1JP27fyxCaHZDoor5F5WGF

I believe the code handling this is in ../core/disputes.go:507-509

As for the root cause of this problem, I repeatedly see this in the logs when this problem occurs:

[ERROR] [service/handleDisputeOpen] failed calc orderID

[hoffmabc]

What would be the downfall of letting this go through instead of killing it here @cpacia @jjeffryes ?

if dispute.VendorContract == nil && vendorPercentage > 0 {
	return errors.New("vendor must provide his copy of the contract before you can release funds to the vendor")
}

[drwasho]

@hoffmabc I commented out this code and tried it, but I run into some other errors, so ultimately getting to the root cause would be the best solution to fix the bug... but I also think we should remove this code anyway since it's more likely than not to prevent a moderator from splitting funds.

[cpacia]

Done