Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back page edit history #667

Closed
vnugent opened this issue Jan 26, 2023 · 8 comments · Fixed by #765
Closed

Bring back page edit history #667

vnugent opened this issue Jan 26, 2023 · 8 comments · Fixed by #765
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@vnugent
Copy link
Contributor

vnugent commented Jan 26, 2023

Use case

When viewing a climb/area page I want to see the edit history

This feature was already implemented and available in the old area page. We just need to port it over.

Old area page: https://openbeta.io/areas/18c5dd5c-8186-50b6-8a60-ae2948c548d1 (click on Edit -> Histor)
New ara page: https://openbeta.io/crag/18c5dd5c-8186-50b6-8a60-ae2948c548d1

@vnugent vnugent added this to the v0.7 milestone Jan 26, 2023
@vnugent vnugent changed the title Show page edit history Bring back page edit history Jan 26, 2023
@vnugent vnugent mentioned this issue Jan 26, 2023
25 tasks
@vnugent vnugent added the help wanted Extra attention is needed label Jan 26, 2023
@vnugent vnugent mentioned this issue Mar 3, 2023
21 tasks
@actuallyyun
Copy link
Collaborator

Hey I don't think the first link is working :

Screenshot 2023-03-23 at 14 32 33

@vnugent
Copy link
Contributor Author

vnugent commented Mar 23, 2023

Thanks for catching this. The test area only exists in production. In development your local app connects to the staging api server which doesn't have the same area id. Maybe we can make the area link configurable, 1 for development and 1 for production.

@saferthanhouses
Copy link
Contributor

Happy to look into this. Are there any designs available?

@saferthanhouses
Copy link
Contributor

Or possibly a simple

Screen Shot 2023-03-24 at 12 33 11 PM

And showing the history popup from the old page on click

@vnugent
Copy link
Contributor Author

vnugent commented Mar 25, 2023

@saferthanhouses thank you for taking on this.

Pointers:

email me viet at openbeta dot io for additional API keys to work with auth0

@saferthanhouses
Copy link
Contributor

@vnugent I'm working on updating this PR so the ChangeHistory data is pulled dynamically - not from getStaticProps as it is currently.

@vnugent
Copy link
Contributor Author

vnugent commented Mar 31, 2023

@saferthanhouses thanks for picking up this task.
Do you think there's a huge benefit in pulling the data dynamically since the majority of our users simple read the pages?

@saferthanhouses
Copy link
Contributor

@vnugent possibly not! But it was a good opportunity to dig into the different SSR strategies the app is using 😆
PR reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants