Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Build Pipeline broken #372

Closed
l4u532 opened this issue Dec 11, 2023 · 3 comments
Closed

PR Build Pipeline broken #372

l4u532 opened this issue Dec 11, 2023 · 3 comments

Comments

@l4u532
Copy link
Contributor

l4u532 commented Dec 11, 2023

@enapupe @vnugent

Something apparently broke the PR build pipeline:

Run docker/login-action@v2
Error: Username and password required

See fx: https://github.com/OpenBeta/openbeta-graphql/actions/runs/7166351784/job/19510256065?pr=371

Might be related to e43370c

@enapupe
Copy link
Contributor

enapupe commented Dec 12, 2023

That's strange, the last main branch build pushed to dockerhub without issues. Maybe someone changed credentials afterwards?
By the way, ideally we should not login to dockerhub if we are just building the container.
I'm adding a patch to skip dockerhub login if it's a PR.

@vnugent
Copy link
Contributor

vnugent commented Dec 12, 2023

It's failing because GitHub prevents contributors without write access to the repo to use/read secrets in PRs (Otherwise someone can submit a PR and print out secrets on the screen).

@vnugent
Copy link
Contributor

vnugent commented Dec 12, 2023

Merged fix #373

@l4u532 can you please rebase your PR #371 and push again to verify the fix?

@l4u532 l4u532 closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants