Changing page size in first page to wide screen will reset after app relaunch

[sriharshachilakapati]

Steps to reproduce:

1. Create a new document. First page will be in 4:3 regular by default.
2. Write something on it.
3. Change page size to Wide (16:9) from the menu.
4. See changes in the UI.
5. Save the document and quit.
6. Reopen OpenBoard.
7. Find page size set back to 4:3 in old document.

Can also be verified by exporting the document in BRD format and opening page000.svg and it will have ub:nominal-size="1280x960" where-as it should actually be ub:nominal-size="1696x960"

Running OpenBoard 1.6.4 on Manjaro Linux, installed from FlatHub. Would be happy to share a sample document for reproducing if required.

[letsfindaway]

Thanks for reporting.

Confirmed and reproducible.

[letsfindaway]

Changing the page size is not considered to be a modification of the page and does therefore not trigger saving the page before leaving. As soon as you make some modification to the page after changing the size, the scene is persisted and the new page size is correctly saved.

So the issue only appears if you modify the page size only and nothing else.

My proposal is to modify the following piece of code:

OpenBoard/src/board/UBBoardController.cpp

Lines 2057 to 2073 in 2f4f94a

	void UBBoardController::setPageSize(QSize newSize)
	{
	if (mActiveScene->nominalSize() != newSize)
	{
	mActiveScene->setNominalSize(newSize);
	saveViewState();
	updateSystemScaleFactor();
	updatePageSizeState();
	adjustDisplayViews();
	QDateTime now = QDateTime::currentDateTime();
	selectedDocument()->setMetaData(UBSettings::documentUpdatedAt, UBStringUtils::toUtcIsoDateTime(now));
	UBSettings::settings()->pageSize->set(newSize);
	}
	}

Add after line 2061:

        mActiveScene->setModified(true);

Edit: a better way would be to move this to UBGraphicsScene as follows:

void UBGraphicsScene::setNominalSize(const QSize& pSize)
{
    if (nominalSize() != pSize)
    {
        mNominalSize = pSize;
        setModified(true);    // modifying the size modifies the scene

        // force redrawing the background
        foreach(QGraphicsView* view, views())
        {
            view->resetCachedContent();
        }

        if(mDocument)
            mDocument->setDefaultDocumentSize(pSize);
    }
}

This makes setting the flag more local. Additionally I added a resetCachedContent to immediately redraw the page size rectangle.