Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Office Tender Page for closed tenders #58

Closed
noamoss opened this issue Feb 23, 2018 · 8 comments
Closed

Create a Office Tender Page for closed tenders #58

noamoss opened this issue Feb 23, 2018 · 8 comments
Assignees

Comments

@noamoss
Copy link

noamoss commented Feb 23, 2018

(Invisoin link: https://projects.invisionapp.com/d/main#/console/7587193/276178413/preview )

image

Open Office Tender (WHERE tender_type = 'office' AND (decision='הסתיים`) dynamic values:

No. data source label value / logic comments
1 any of the fields none if a value changed during TODAY <= LAST_UPDATE_DATE + 7 daysvalue should be עודכן!, if TODAY <= START_DATE + 7 value should be חדש! do not use the decision field value here, as it is not reflecting what we intend to show with this label.
2 decision none מכרז שנסגר: based on the decision field: if decision == הסתיים other values to be handled in separate issues
3 LAST_UPDATE_DATE עדכון אחרון date dd.mm.yyyy
4 START_DATE פרסום ראשון date dd.mm.yyyy
5 DESCRIPTION BOLD
6a decision none הושלם תהליך הרכש: based on the decision field: if decision == `הסתיים. notice 2nd part of the label, see 6b
6b quarterly_contract_spending_reports none three options, based on the procurement status: הושלם תהליך הרכש - לא החלה התקשרות, הושלם תהליך הרכש - החלה התקשרות, הושלם תהליך הרכש והושלמה ההתקשרות notice 6b can appear only after 6a has happened
7 PUBLISHER none in the future it should be clickable and lead to a publisher entity page, currently simple text
8 quarterly_contract_spending_reports.supplier_name none A. if the tender_id appears in quarterly_contract_spending_reports.manof_ref and count('supplier_name') == 1, display supplier_name). B. if count('supplier_name') > 2, display [num] ספקים`. C. Otherwise, leave empty
9a quarterly_contract_spending_reports.executed, quarterly_contract_spending_reports.volume pie chart
9b quarterly_contract_spending_reports.executed, quarterly_contract_spending_reports.volume 'עד כה בוצעו...% מתוך:` exectued / volume dd% (round result). Notice this formula should relate to ALL relevant suppliers (using manof_ref)
9c quarterly_contract_spending_reports.executed none sum of all exectued values for the relevant manof_ref add NIS symbol to value
10 SUBJECTS label per each value. Each label should be linked to a search results page of procurement_tenders from the same topic
11a tender_id מספר מנו"ף tender_id
11b tender_type סוג המכרז: if tender_type == office --> משרדי
11c CLAIM_DATE מועד סגירה: ... בשעה... dd.mm.yyyy + HH:MM:
11d CONTACT אנשי קשר: email adresses should be clickable and open user's email client
12a actionable A # to be handled on a follow #51
12b actionable B # to be handled on a follow #51
13 (table intro) table headers : הזוכים במכרז, סכום ההתקשרות, עד כה שולם values in this block are to be calculated by the intersection between current tender_id and quarterly_contract_spending_reports.manof_ref. Table should be sorted by the value amount (13b) in a decreasing order (biggest value, first row)
13a quarterly_contract_spending_reports.supplier_name in the future it would be linked to future entity page, currently nothing special
13b quarterly_contract_spending_reports.volume none, add a NIS symbol sum of quarterly_contract_spending_reports.volume of the concrete supllier under the concrete manof_ref don't round result, display real number (up to 2 digits after demical point)
13c quarterly_cquarterly_contract_spending_reports.executed` none, add a NIS symbol sum of quarterly_contract_spending_reports.executed of the concrete supllier under the concrete manof_ref don't round result, display real number (up to 2 digits after demical point)
13d link to the relevant התקשרות page
14 (table intro) table shows chronological history of the tender, in a reversed order. Two type of updates to be included: tender status change (bolded), payment (taken from the quarterly report) (bolded row), uploading/updating file (normal text for the entrie row)
14a quarterly_cquarterly_contract_spending_reports.volume, quarterly_cquarterly_contract_spending_reports.executed no headers pie chart of the executed out of the total volume the pie chart refers to the tender's total exectued out of the total approved values, not to be confused with 13 above
14b (update date -- from either quarterly_cquarterly_contract_spending_reportsorprocurement_tenders` if date == Today --> היום, if Today - date <= 7 --> ימים x לפני, if Today- date < 4 weeks, divide days number by 7 --> לפני כ-x שבועות, otherwise: raw date (DD.MM.YYYY)
14c quarterly_contract_spending_report.PAGE_URL or quarterly_contract_spending_reports.REPORT-URL don't show address, just display the icon with a relevant link to be opened in a new tab
14d update message needs to set logic to be handled in a separate issue, to be hanled in #52
15 grid intro, based on procurement_tenders.DOCUMENTS קבצים מצורפים
15a update_time none (update date -- from either quarterly_contract_spending_reports or procurement_tenders) if date == Today --> היום, if Today - date <= 7 --> ימים x לפני, if Today- date < 4 weeks, divide days number by 7 --> לפני כ-x שבועות, otherwise: raw date (DD.MM.YYYY)
15b icon + file name icon to be set by the file type extention (doc/pdf/xls/csv), each element should be linked to the link address. If the number of elements is bigger than 3, start a new row of elements
@noamoss noamoss self-assigned this Feb 23, 2018
@noamoss
Copy link
Author

noamoss commented Jun 9, 2018

@akariv I think this is ready to go, notice changes in the following elements:

6 (was divided into 6a + 6b)

@noamoss noamoss assigned akariv and unassigned noamoss Jun 9, 2018
@noamoss noamoss changed the title Create a Office Tender Page for closed tenders [in process] Create a Office Tender Page for closed tenders Jun 9, 2018
@akariv
Copy link
Member

akariv commented Jun 9, 2018

@noamoss
I don't follow the changes on 2 + 6
What should appear in the tag after the publisher name?
This sentence is unclear:

הושלם תהליך הרכש: based on the decision field: if decision == חדש or decision == עודכן.

@noamoss
Copy link
Author

noamoss commented Jun 9, 2018

@akariv
2a was fixed (decision value should be "הסתיים" ), hope it makes thing clear for both 2 and 6.

What should appear in the tag after the publisher name?

After the publisher there should be an arrow and then the supllier name.
I hope I understand your question correctly, not sure though. Please specify element number (from the demo) to clarify.

@akariv
Copy link
Member

akariv commented Jun 9, 2018

I guess you meant 6a, not 2a - and it does clarify a bit.
When does 6a apply? What is the time period between 'הסתיים' and 'הושלם תהליך הרכש - לא החלה התקשרות'?

@noamoss
Copy link
Author

noamoss commented Jun 9, 2018

@akariv

I guess you meant 6a, not 2a - and it does clarify a bit.

correct, sorry.

When does 6a apply?

always - meaning - once the decision field value is הסתיים you should show this word. 6b to be added according to the existence/absence of this tender the any/none quarterly procurement report.

What is the time period between 'הסתיים' and 'הושלם תהליך הרכש - לא החלה התקשרות'?

the time does not matter, only the available data. maybe we should change 'הושלם תהליך הרכש - לא החלה התקשרות' to הושלם תהליך הרכש - לא אותר דיווח על התקשרות רלוונטית? what do you think?

@akariv
Copy link
Member

akariv commented Jun 10, 2018

The thing I don't get still is what data would result in showing הסתיים', and which in showing 'הושלם תהליך הרכש - לא החלה התקשרות'. Both are about decision==הסתיים and no contracts, no?

@noamoss
Copy link
Author

noamoss commented Jun 10, 2018

הסתיים תהליך הרכש
(6a)
will always be displayed with an addition (6b) with extra info about the actual procurement status.

@akariv
Copy link
Member

akariv commented Jun 10, 2018

got it now

@akariv akariv closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants