Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Site Footer Markup [2h] #3

Closed
noamoss opened this issue Oct 1, 2017 · 7 comments
Closed

Create Site Footer Markup [2h] #3

noamoss opened this issue Oct 1, 2017 · 7 comments

Comments

@noamoss
Copy link

noamoss commented Oct 1, 2017

Elements to include:

  • Usage License
  • Github Link
  • 3-4 sponsors
@noamoss noamoss added this to the User Displays milestone Oct 1, 2017
@noamoss noamoss changed the title Create Site Footer [2h] Create Site Footer Markup [2h] Oct 1, 2017
@akariv
Copy link
Member

akariv commented Feb 22, 2018

@noamoss is there a spec for the footer?

@noamoss
Copy link
Author

noamoss commented Feb 23, 2018

@akariv not yet, will wait for my & @mushon meeting and hope to send it.

@mushon
Copy link

mushon commented Jul 16, 2018

New footer with more details.
After consulting with @shevyk we agreed not to include the logos on every page but to place them on a segment of the about page instead:
https://projects.invisionapp.com/d/main#/console/7587193/308992414/inspect

@mushon mushon removed their assignment Jul 16, 2018
@noamoss
Copy link
Author

noamoss commented Jul 16, 2018

@mushon ok, it means designing an about page with supporters logos/links section, let's do so on #17.

Please see my comments on InVision, and reassign to me when done.

@noamoss noamoss assigned mushon and unassigned noamoss Jul 16, 2018
@mushon mushon assigned noamoss and unassigned mushon Jul 23, 2018
@noamoss
Copy link
Author

noamoss commented Jul 23, 2018

@akariv ready for development, please see the notes in the InVision

@noamoss noamoss assigned akariv and unassigned noamoss Jul 23, 2018
@akariv akariv closed this as completed Aug 1, 2018
@akariv akariv removed the prioritised label Aug 1, 2018
@noamoss
Copy link
Author

noamoss commented Aug 2, 2018

@akariv

the current footer is still missing:

  • the fixed license text (as provided in the design)
  • about
  • staff
  • privacy policy.

@noamoss noamoss reopened this Aug 2, 2018
@akariv akariv removed the prioritised label Aug 2, 2018
@noamoss
Copy link
Author

noamoss commented Aug 3, 2018

@akariv missing links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
On going work
Awaiting triage
Development

No branches or pull requests

3 participants