Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File open doesnt remember last folder used. #270

Closed
sharmstr opened this issue Nov 16, 2022 · 4 comments
Closed

File open doesnt remember last folder used. #270

sharmstr opened this issue Nov 16, 2022 · 4 comments

Comments

@sharmstr
Copy link
Collaborator

As of .336 file open defaults to last folder used before upgrading.

How I confirmed.

Upgraded to .336.
File open would always default to my download folder.
Reverted back to previous version.
Opened a file in a new location (/gcode/Camera Jig)
Upgraded to .336
Now file open defaults to /gcode/Camera Jig
Opened file from /gcode/cuttingboard
Quit control.
File open still defaults to /gcode/Camera Jig

@sharmstr
Copy link
Collaborator Author

Seems to work ok when running from a browser window localhost:3000. Got the idea to check it from here: electron/electron#1780

@petervanderwalt
Copy link
Contributor

We do have the accept attrib on the input. We upgraded from Electron 9 to 19 (long overdue)
But I think (can't yet find confirmation) that Electron wants us to stop using the Chromium dialogs for things like this and implement native dialogs https://www.electronjs.org/docs/latest/api/dialog#dialogshowopendialogbrowserwindow-options

@petervanderwalt
Copy link
Contributor

https://discord.com/channels/745037351163527189/1052326878456848464 still no response to Bug report on Electron, trying discord

@OpenBuilds OpenBuilds deleted a comment from brrian11 Dec 13, 2022
@OpenBuilds OpenBuilds deleted a comment from CiaranWhelan Dec 13, 2022
@OpenBuilds OpenBuilds deleted a comment from CiaranWhelan Dec 13, 2022
@petervanderwalt
Copy link
Contributor

Beta test of Native File dialogs in 1.0.342 - let us know if you find any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants