Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import utilities from hextof-processor #262

Open
3 of 13 tasks
steinnymir opened this issue Nov 13, 2023 · 1 comment
Open
3 of 13 tasks

Import utilities from hextof-processor #262

steinnymir opened this issue Nov 13, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@steinnymir
Copy link
Member

steinnymir commented Nov 13, 2023

Some utilities which could be ported from hextof processor:

from src/processor/utilities/calibration.py

  • filterCircleDLDPos: a geometric filtering tool (could be expanded)
  • correctOpticalPath: might be already in momentum/energy calibration
  • gen_sector_correction: parameter generation method for dld_sector_correction

from src/processor/utilities/diagnostics.py

from src/processor/utilities/io.py

  • update units in config.py
  • save binned results as tiff
  • save binned results as hdf5

from src/processor/utilities/misc.py:
I am not sure if these are then too specific for SED, and if they should be extenalized in a different repo. Open to suggestions!

  • fluence and absorbed_energy_density
  • effective_gaussian_area
  • gaussian2D, lorentzian2D etc...

from src/processor/utilities/vis.py:

  • Orthoslices3D and 4D: visualization tools for 3 and 4 dimensional xarray.DataArrays.

Some of these might already be implemented, and if so, please do tick them as complete, and mention the function name in the comments.
Some might not belong to this repo, but are rather evaluations post binning. We can discuss if these should be included in SED or if we should make a separate repo/project for that.

@rettigl
Copy link
Member

rettigl commented Nov 15, 2023

correctOpticalPath: might be already in momentum/energy calibration

If this is what I think it is, then this is implemented in the energy correction workflow.

save binned results as tif
save binned results as hdf5

these exist as the save function. Do we need anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants