Use a fleshed out and supported coding style

[versable]

As the code rarely follows the proposed style. And the style guideline is rather short (http://opencpn.org/ocpn/code-style). I would move to a well established code style that supports linters, autoformatters, IDE plugins, etc...

A great tool that I regularly use is clang-format, which formats any file I edit on the fly. ( IDE set to call clang-format on save ). It supports the following formats: LLVM, Google, Chromium, Mozilla, WebKit.

It would be a good step to make the code a bit cleaner, and the effort is minimal ( except merging current pull request would be time consuming )

[versable]

Here is a guide on how to use clang-format in Visual Studio: http://visualstudioextensions.vlasovstudio.com/2013/11/05/format-c-code-intelligently-in-visual-studio-with-clang-format/

[nohal]

versable...
New code more or less follows the style, of course nobody ever reformatted the legacy codebase
IMO If to be done, we should first announce it is going to happen, set the enforcing policy, improve the documentation, finish and merge the big pulls. Then do the reformatting, not the other way around
As almost nobody of us uses VS, are you aware of integrations for clang-format into C::B and KDevelop?

Pavel

[versable]

For C::B I'd use Scripting Commands (http://wiki.codeblocks.org/index.php?title=Scripting_commands)

[[GetEditorManager().SaveActive();]] cmd.exe /c "timeout" "1" && "$(CODEBLOCKS)\sdk\LLVM\bin\clang-format.exe"

I'm sure there is something similar in KDevelop

Personally I use sublime, which has a working plugin for clang-format.

[keesverruijt]

FWIW -- I'm going to use @versable 's idea of using clang-format with the Google style in br24radar_pi. My .clang-format is:

   BasedOnStyle:                                   Google
   PenaltyBreakString:                             999999999
   ColumnLimit:                                    132

The latter two form my workaround to keep clang-format from breaking up wxT() and _() macro content too much.

[leamas]

to use @versable 's idea of using clang-format

I have been thinking the same, actually. That said, I don't really care about the actual style used as long as it is consistent.