Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of properly tagged releases in git / signed source tarballs. #1132

Closed
MrElendig opened this issue Aug 30, 2018 · 6 comments
Closed

Lack of properly tagged releases in git / signed source tarballs. #1132

MrElendig opened this issue Aug 30, 2018 · 6 comments

Comments

@MrElendig
Copy link

MrElendig commented Aug 30, 2018

Several times now, last with 4.8.6, releases have been made on the download page[1][2] without them being tagged in git. Combined with a lack of (signed/check-summed) source tarball on the download page that makes packaging stable releases of opencpn infeasible.
Linking to a branch[3] on GH is not good enough since that doesn't tell us exactly where in the history/from which commits the release was made.

[1]https://opencpn.org/OpenCPN/info/downloadopencpn.html
[2]https://web.archive.org/web/20180829175255/https://opencpn.org/OpenCPN/info/downloadopencpn.html
[3]https://github.com/OpenCPN/OpenCPN/tree/o486

@tchiwam
Copy link

tchiwam commented Aug 31, 2018

Holding for the version bump in our systems for the same reason.

@greno4ka
Copy link

Ping?

@bdbcat
Copy link
Member

bdbcat commented Oct 27, 2018

Hello...
I understand the issue. The point at which branch o486 was forked was not tagged in master. Subsequent changes were made in branch o486. As a result, the actual release content of o486 is not in master. It only exists in branch o486. So a back-tag of master will not help much today.

Branch o486 is tagged at the proper point, if that helps.

Dave

@nohal
Copy link
Collaborator

nohal commented Oct 27, 2018

Dave...

The tag does not have to be in master. What o486 branch is missing is the last commit actually changing the version number and then the v4.8.6 tag.

Pavel

@bdbcat
Copy link
Member

bdbcat commented Oct 27, 2018

Done.

Was done locally, just not pushed. Sorry for the lag.

Dave

@nohal
Copy link
Collaborator

nohal commented Oct 27, 2018

I have tagged it and created a release.

Closing until next time ;)

@nohal nohal closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants