Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Plugin Version Numbering (small bug) #3438

Closed
rgleason opened this issue Sep 22, 2023 · 2 comments
Closed

Bug: Plugin Version Numbering (small bug) #3438

rgleason opened this issue Sep 22, 2023 · 2 comments
Labels
bug

Comments

@rgleason
Copy link
Collaborator

Please see the report in Watchdog

rgleason/watchdog_pi#70 (comment)
@rgleason rgleason added the bug label Sep 22, 2023
@leamas
Copy link
Collaborator

leamas commented Sep 22, 2023 •
edited

This seems to be a bug in the plugin catalog eventually caused by a faulty PR to opencpn/plugins. Core OpenCPN does nothing wrong here, it just reflects the version as defined in the catalog.

In other words, this should probably just be closed as NOTABUG.

One a sidenote getting the version from the catalog is sort of a hack made necessary since we did not have complete version data available in the binary plugin API. From API 1.18 there are methods in the plugin API which returns complete version data, obsoleting the version in the catalog. That should make things more robust in the long run.

@rgleason
Copy link
Collaborator Author

NOTABUG We need to move the plugin API up to 118, but what are the pitfalls of doing that?

@leamas leamas mentioned this issue Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leamas @rgleason