Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Validation Tools don't fail on 404 page not found errors #988

Open
TwoCanPlugIn opened this issue Aug 31, 2023 · 0 comments
Open

Comments

@TwoCanPlugIn
Copy link
Contributor

Plugins with invalid web site URL's pass validation checks.

In check-metadata-urls.sh, the test is:

if not status or status >= 400:
dot = 'E'
stats.url_errors.append(path + ": " + tag + ": " + str(status))
r = False

For example the info url for squiddio is https://opencpn.org/OpenCPN/plugins/squiddio.html which returns with the following page https://opencpn.org/404page.shtml

I guess that the OpenCPN web site is redirecting the invalid url to the landing page and this not returning a 404 error ?

The plugins without valid info url's are:

squiddio
otidalplan
objsearch
nv charts
Earth Explorer
DashboardSK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant