Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel Connector not setting indicator expiry date #2092

Closed
nzjoshellis opened this issue May 2, 2024 · 1 comment · Fixed by #2173
Closed

Sentinel Connector not setting indicator expiry date #2092

nzjoshellis opened this issue May 2, 2024 · 1 comment · Fixed by #2173
Assignees
Labels
bug use for describing something not working as expected filigran support [optional] use to identify an issue related to feature developed & maintained by Filigran. needs more info Intel needed about the use case solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@nzjoshellis
Copy link

Description

The sentinel connector can be utilized to ingest IOCs into Microsoft Sentinel & Microsoft Defender for Endpoint via the Graph API. The expiry date of the indicators is specified in the connector configuration (eg. expire after 30 days) however this is not being set on the indicators when they are created.

Environment

  1. OS (where OpenCTI server runs): Ubuntu 22.04
  2. OpenCTI version: 6.0.10
  3. OpenCTI client: frontend
  4. Other environment details: Sentinel Connector version 6.0.10 (also tested 5.12.32)

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Set up the Sentinel Connector using "TARGET_PRODUCT=Microsoft Defender ATP" & EXPIRE_TIME=30
  2. Create a new indicator with an expiry more than 1 day in the future. This should then be pushed through to Microsoft Defender ATP
  3. In the Defender for Endpoint Portal, review the indicator and note the expiry date is set 24 hours from when it was created

Expected Output

Ideally the expected expiry should be synced through which was set on the indicator. The sentinel connector configuration sets an age on it which is configurable (set to 30 days).

Actual Output

The age is set to 24 hours after the IoC was created. This is the default configuration when no expiry is set I believe.

Additional information

In the script which runs (https://github.com/OpenCTI-Platform/connectors/blob/master/stream/sentinel/src/sentinel.py) - line 255 is responsible for setting this date, I believe it should be "expirationDateTime" and not "expiration_datetime".

When other indicator types are created (email & File) they use the correct property name (line 277 & 304).

More information on this API is here: https://learn.microsoft.com/en-us/graph/api/tiindicators-post?view=graph-rest-beta&tabs=http#request

@nzjoshellis nzjoshellis added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels May 2, 2024
@nino-filigran
Copy link

@Megafredo & @helene-nguyen could you have a look when you have time please?

@nino-filigran nino-filigran added needs more info Intel needed about the use case and removed needs triage use to identify issue needing triage from Filigran Product team labels May 2, 2024
@SamuelHassine SamuelHassine added this to the Release 6.1.1 milestone May 4, 2024
@nino-filigran nino-filigran added filigran team use to identify PR from the Filigran team filigran support [optional] use to identify an issue related to feature developed & maintained by Filigran. and removed filigran team use to identify PR from the Filigran team labels May 7, 2024
@Megafredo Megafredo self-assigned this May 13, 2024
@Jipegien Jipegien modified the milestones: Bugs backlog, Release 6.2.0 May 23, 2024
@Megafredo Megafredo linked a pull request May 24, 2024 that will close this issue
4 tasks
@Megafredo Megafredo added the solved use to identify issue that has been solved (must be linked to the solving PR) label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected filigran support [optional] use to identify an issue related to feature developed & maintained by Filigran. needs more info Intel needed about the use case solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants