Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressing an entity does not suppress its relations #1428

Closed
manonviallet opened this issue Jun 18, 2021 · 1 comment
Closed

Suppressing an entity does not suppress its relations #1428

manonviallet opened this issue Jun 18, 2021 · 1 comment
Assignees
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@manonviallet
Copy link
Contributor

Description

When integrating information in a graph, if an entity is suppressed, all the relations created within the graph with this entity are saved and continue to exist. Therefore, even though the relation was created only once in the context of this report, and can no longer be visualized in the report, it can be visualized and called upon through the investigation space.

This is problematic as if during integration the analyst realize it integrated the wrong campaign/intrusion set/TTPs etc, although he/she has suppress the object to replace it by another, the false relations with the former entity are remaining in the DB. As a result, the relations keep appearing in the kill chain, and in the investigation graph of the entity, as if they were still valid.

Was wondering is this choice is deliberate (because we can create relations with no report in the platform) or because the number of reports the relation is associated with is not counted ?

It would be relevant to keep the relation if there are still several reports in which it exists, but to suppress it if there is only one report. Another solution would be to ask when the entity is suppressed, if the person want to keep the relations or delete it also ? to have this pop up only if the relation had only this report linked to ?

Environment

Tested in the demo (V4.5.5)

Here, the malware has been suppressed of the knowledge graph of the report and put again. Although all the relations have been suppressed when then malware was, they are still offered when we want to generate anew relation.
problem_relation_suppression

In the investigation graph, the malware has all these ttps although the relation is no longer in a report
Test

In the kill chain view also the TTPs are visible.
killchain

@manonviallet manonviallet added question Further information is requested feature use for describing a new feature to develop labels Jun 18, 2021
@SamuelHassine
Copy link
Member

Hello @manonviallet,

It's not intentional. The idea of the popup to ask confirmation before deleting all relations is a good idea :)

@SamuelHassine SamuelHassine added this to the Release 5.2.0 milestone Aug 10, 2021
@SamuelHassine SamuelHassine self-assigned this Oct 2, 2022
@SamuelHassine SamuelHassine removed the question Further information is requested label Oct 2, 2022
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

2 participants