Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated filters with deleted entities as value #3179

Closed
Archidoit opened this issue Apr 17, 2023 · 2 comments
Closed

Deprecated filters with deleted entities as value #3179

Archidoit opened this issue Apr 17, 2023 · 2 comments
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@Archidoit
Copy link
Member

Use case

When an entity is deleted, filters with this entity in their values are still present in the platform.

Current Workaround

If an entity is deleted, what do we do with elements with this entity in their filters?
Example of concerned filters: labelledBy (a deleted label) / contains (a deleted entity) / fromId / toId / createdBy...
Example of elements that can have such deprecated filters: triggers, streams, taxii collection, entity lines display...

Example: a stream with a filter pointing to a deleted entity.
What do we do with the stream?
- delete the stream ?
- mark the stream as deprecated ?
- delete the deprecated filter in the stream? (and even delete the stream if no filter is remaining)

@SamuelHassine SamuelHassine added feature use for describing a new feature to develop P2 and removed P2 labels Apr 17, 2023
@SamuelHassine SamuelHassine added this to the Release 5.9.0 milestone Apr 17, 2023
@Jipegien Jipegien modified the milestones: Release 5.11.0, Short-term candidates Jul 26, 2023
@Archidoit
Copy link
Member Author

Will be resolved in #2686

@SamuelHassine SamuelHassine removed the P1 label Jan 6, 2024
@nino-filigran nino-filigran added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 29, 2024
@nino-filigran
Copy link

nino-filigran commented Feb 29, 2024

Closing this issue given your comment @Archidoit

@nino-filigran nino-filigran added the duplicate use to identify issue already existing label Feb 29, 2024
@SamuelHassine SamuelHassine removed duplicate use to identify issue already existing sharing labels Mar 1, 2024
@SamuelHassine SamuelHassine modified the milestones: Short-term candidates, Release 6.0.2 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

4 participants