Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User data ingest not compatible with "enforced references" (Import, CSV mapper, ...) #4839

Open
labo-flg opened this issue Nov 2, 2023 · 2 comments
Labels
feature use for describing a new feature to develop

Comments

@labo-flg
Copy link
Member

labo-flg commented Nov 2, 2023

Description

When some entities have the option "Enforce references", we cannot import them from a CSV using our new CSV mappers.
The backend checks for the validity of the gql input and it lacks the mandatory externalReferences.

Environment

5.11.12

Reproducible Steps

  1. Create a simple mapper as explained in this comment.

  2. Test it with the csv file provided in same comment --> you will get the validation error.

  3. Try to import data using this same file and mapper --> it won't work. Backend logs show the same error (frontend shows no feedback, but that's another issue).

Expected Output

?????

That's a good question actually.
Once you enforce references, what is supposed to be possible ?

@labo-flg labo-flg added the bug use for describing something not working as expected label Nov 2, 2023
@richard-julien richard-julien added the needs triage use to identify issue needing triage from Filigran Product team label Nov 3, 2023
@richard-julien
Copy link
Member

Not a CSV specific problem for me. Its global to file ingest. Pinging @Jipegien

@Jipegien
Copy link
Member

This is not a bug. Enforced references are not covered by CSV mappers and any other means to import multiple Objects in one shot. This is a really complex problem for a very little subset of advanced users.

We will tackle this, later, in collaboration with end users to find a good trade off.

@Jipegien Jipegien added feature use for describing a new feature to develop and removed bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Nov 13, 2023
@Jipegien Jipegien modified the milestones: Release 5.12.0, Long-term candidates Nov 13, 2023
@richard-julien richard-julien changed the title With enforced references, CSV mapper won't work User data ingest not compatible with "enforced references" (Import, CSV mapper, ...) Nov 13, 2023
@SamuelHassine SamuelHassine added filigran team use to identify PR from the Filigran team and removed filigran team use to identify PR from the Filigran team labels Apr 20, 2024
@Jipegien Jipegien removed this from the Long-term candidates milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop
Projects
None yet
Development

No branches or pull requests

4 participants