Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default marking are not cleaned when marking is deleted, leading to full crashed platform #5835

Closed
SamuelHassine opened this issue Feb 6, 2024 · 1 comment
Closed

Default marking are not cleaned when marking is deleted, leading to full crashed platform #5835

SamuelHassine opened this issue Feb 6, 2024 · 1 comment
Assignees
@SouadHadjiat @jpkha
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 5.12.32

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Feb 6, 2024 •
edited

Description

  1. Create a group
  2. Add a some markings
  3. Add a DEFAULT marking
  4. Delete the marking (in marking definition list)

=> In Elastic, the rel_accesses-to is cleaned, but not the default_marking field, because it is not a rel_ and no logic has been implemented to do so.

Result as a user part of this group, platform is in full error state. Group is not accessible and cannot be updated. Need to clean default marking in Elastic
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Feb 6, 2024
@Kedae Kedae added critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team labels Feb 6, 2024
@jpkha jpkha mentioned this issue Feb 6, 2024
Merged
@richard-julien
Copy link
Member

Dont forget the associated backend test :)

@jpkha jpkha closed this as completed Feb 8, 2024
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 8, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouadHadjiat SouadHadjiat

@jpkha jpkha

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 5.12.32
Development

No branches or pull requests
5 participants
@richard-julien @SouadHadjiat @SamuelHassine @jpkha @Kedae