Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The way to handle external ref is inconsistent #6074

Open
nino-filigran opened this issue Feb 22, 2024 · 1 comment · May be fixed by #6727
Open

The way to handle external ref is inconsistent #6074

nino-filigran opened this issue Feb 22, 2024 · 1 comment · May be fixed by #6727
Assignees
Labels
bug use for describing something not working as expected
Milestone

Comments

@nino-filigran
Copy link

nino-filigran commented Feb 22, 2024

Description

We had a bug to fix the behavior of external references in reports.
As mentioned in this comment of the same ticket, the behavior of enforcing reference is bigger.

Environment

Demo

Reproducible Steps

Edit an entity while having external reference

  1. Have external reference enforced for your entity
  2. Click on an entity (ex report) that have an external reference
  3. Click on edit
  4. Click on the field external ref
  5. You only see the external ref of the report, not the full list of external refs of your platform and cannot select existing ones already created that do not pertains to your entity.

Expected output:
You should see the list of all the external refs to be able to add another one.

Sharing entity to an org

  1. Have external reference enforced for your entity
  2. Click on an entity (ex report) that have an external reference enforced
  3. Click on share to org
  4. select an org
  5. You got an error message because you have not added any external ref

Expected output:
It would help if you were prompted the pop up to add an external ref instead of having an error message.

Remove all external references while enforce external reference is enabled

  1. Have external reference enforced for your entity
  2. Click on an entity (ex report) that have an external reference enforced and have some external ref
  3. Remove all external ref

Expected output:
You should not be able to remove all external ref. At least always 1 external ref must remains in the entity.

Adding relations (core ) is sometimes possible without having to add an external ref

  1. Have external reference enforced for your entity
  2. Go to your entity and click on add relation

Expected output:
You should not be able to add a relation without adding an external ref. The pop up must be pormpted if not in the form.

@nino-filigran nino-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Feb 22, 2024
@nino-filigran nino-filigran added this to the Release 6.0.1 milestone Feb 22, 2024
@Kedae
Copy link
Member

Kedae commented Feb 22, 2024

/!\ All this bug fix MUST be covered by e2e testing

@Kedae Kedae modified the milestones: Bugs backlog, Release 6.2.0 May 20, 2024
@labo-flg labo-flg changed the title The way to handle external ref is inconsitent The way to handle external ref is inconsistent Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants