Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a relation in a grouping knowledge graph removes it in all containers #6484

Closed
JeremyCloarec opened this issue Mar 26, 2024 · 0 comments · Fixed by #6491
Closed
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@JeremyCloarec
Copy link
Contributor

Description

When removing a relation from a groupings graph, the relation is deleted even if it is contained in an other container.

Reproducible Steps

  1. Create a new report
  2. Go to the knowledge graph, add two entities and create a relationship between them
  3. Create a new grouping
  4. Go to the knowledge graph, add the two same entities and add the same relationship between them
  5. Remove this relationship

Expected Output

The relationship still being there in the report

Actual Output

The relationship is deleted

Additional information

We are forced to do a cascade remove in groupings, but in reports we are prompted to choose between only removing the relation in this container or if we want to do a cascade remove. Maybe we also want to add this option in groupings and other containers?

@JeremyCloarec JeremyCloarec added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 26, 2024
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Mar 26, 2024
@Archidoit Archidoit self-assigned this Mar 26, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.9 milestone Mar 26, 2024
@Archidoit Archidoit added the solved use to identify issue that has been solved (must be linked to the solving PR) label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants