Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] :If no location is selected while saving a file the app crashes #479

Closed
secretkontributer opened this issue Feb 25, 2024 · 2 comments · Fixed by #480
Closed

[Bug] :If no location is selected while saving a file the app crashes #479

secretkontributer opened this issue Feb 25, 2024 · 2 comments · Fixed by #480

Comments

@secretkontributer
Copy link

Avogadro version: (please complete the following information from the About box):

  • Avogadrolibs: 1.99.0
  • Qt: (e.g., 5.9.5)

Desktop version: (please complete the following information):

  • OS: Ubuntu
  • Version :23.10

Describe the bug
App carshes when you dont select the location in which you want to save the file .

To Reproduce
Steps to reproduce the behavior:

  1. Go to save menu option .(You can recreate this bug with save as also)
    Screenshot from 2024-02-25 12-46-37

  2. Click on Save or Save As option . A window will pop up for selecting the location.

screenshot
3.Now dont specify any location just exit from the screen shown in above picture.(Basically press the cancel button on the top left corner)
Screenshot from 2024-02-25 12-47-25
4. The App will crash .
5. Console output is given in the picture attached below.
Screenshot from 2024-02-25 12-48-42
Expected behavior
App should not crash

Additional context
Assert statement in the file location given in the console leads to this line.
Screenshot from 2024-02-25 12-52-52

@avo-bot
Copy link

avo-bot commented Feb 25, 2024

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/if-not-selected-any-location-while-saving-the-file-the-app-carshes/5323/1

@ghutchis ghutchis transferred this issue from OpenChemistry/avogadrolibs Mar 3, 2024
Copy link

welcome bot commented Mar 3, 2024

Thanks for opening your first issue here! Please try to include example files and screenshots if possible. If you're looking for support, please post on our forum: https://discuss.avogadro.cc/

ghutchis added a commit to ghutchis/avogadroapp that referenced this issue Mar 3, 2024
Fixes OpenChemistry#479

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
vinayakjeet pushed a commit to vinayakjeet/avogadroapp that referenced this issue Apr 17, 2024
Fixes OpenChemistry#479

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Vinayakjeet Singh Karki <139736674+vinayakjeet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants