Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE_SPGLIB only installs header file without USE_QT, and also installs SpaceGroup.a with USE_QT #610

Closed
yurivict opened this issue Jun 4, 2021 · 1 comment

Comments

@yurivict
Copy link
Contributor

yurivict commented Jun 4, 2021

Avogadro version: (please complete the following information from the About box):

  • Avogadrolibs: 1.94.0
  • Qt: 5.15.2

Desktop version: (please complete the following information):

  • OS: FreeBSD
  • Compiler: clang-11

Describe the bug
The header include/avogadro/core/avospglib.h and the corresponding library lib/avogadro2/staticplugins/SpaceGroup.a should be installed together. Currently USE_SPGLIB only enables the header, and then USE_QT enables the library.
If Qt is required for USE_SPGLIB it should break and say so when USE_SPGLIB=ON USE_QT=OFF

@yurivict yurivict changed the title USE_SPGLIB only installs header file without USE_QT, and installs SpaceGroup.a with USE_QT USE_SPGLIB only installs header file without USE_QT, and also installs SpaceGroup.a with USE_QT Jun 4, 2021
@ghutchis
Copy link
Member

No, I think this is the correct behavior. The SpaceGroup.a is the Qt-based plugin for the GUI. The header can be used, e.g, by the Jupyter Python code. Right now, it doesn't use spacegroup.h but it will. The underlying non-Qt code uses spglib and doesn't need SpaceGroup.a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants