Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fe2CO3-Iron(II) carbonate in crystals/carbonates folder #1

Closed
prabhxjottsingh opened this issue Oct 3, 2021 · 5 comments · Fixed by #2
Closed

Add Fe2CO3-Iron(II) carbonate in crystals/carbonates folder #1

prabhxjottsingh opened this issue Oct 3, 2021 · 5 comments · Fixed by #2
Assignees

Comments

@prabhxjottsingh
Copy link
Contributor

Hey, I want to contribute in this project and want to add, Fe2CO3 cystals .cif file in the crystals folder, in carbonates topic, as I didn;t find this molecule and it is an important iron ore , so I believe it must be there :)

@ghutchis
Copy link
Member

ghutchis commented Oct 4, 2021

We generally get the CIF files from the Crystallographic Open Database: http://crystallography.net/cod/

I do see siderite, FeCo3 http://crystallography.net/cod/5000036.html

If you can point me to appropriate COD entries, I'd be happy to add the files. (The COD includes all minerals in the American Mineralogist database, so even uncommon ores and minerals are included.)

@prabhxjottsingh
Copy link
Contributor Author

Oh I am really sorry, I mistyped FeCO3 as Fe2CO3.

I was actually talking about Siderite (FeCO3) only, and thanks for telling me the source.

Can you assign this to me ?? I would love to contribute my part in the project. :)

@prabhxjottsingh
Copy link
Contributor Author

Hey, @ghutchis , sorry but just wanted to ask if its okay for me to ask you to label it as hacktoberfest-accepted ??
If its not then also its fine, but just wanted to know.
Thanks in advance for your response. :)

@ghutchis
Copy link
Member

ghutchis commented Oct 4, 2021

I don't think that's needed, since it's merged. Although I do think I'd need to mark the project as part of hacktoberfest.

@prabhxjottsingh
Copy link
Contributor Author

Oh okay Got it, thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants