Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import CDF with RetentionUnit="s" specified #489

Closed
avasyanin opened this issue Mar 28, 2024 · 3 comments
Closed

Import CDF with RetentionUnit="s" specified #489

avasyanin opened this issue Mar 28, 2024 · 3 comments

Comments

@avasyanin
Copy link

CDF files exported by Chromatec Analytic 2.6 program have RetentionUnit specified as "s", not "seconds", so their time scale after reading by OpenChrom is incorrect. The issue probably can be easily solved by adding "s" to the line 87 of https://github.com/OpenChrom/openchrom/tree/develop/openchrom/plugins/net.openchrom.csd.converter.supplier.cdf/src/net/openchrom/csd/converter/supplier/cdf/io/support/AbstractCDFChromatogramArrayReader.java file:

if(unit.equals("seconds") || unit.equals("Seconds")) {

Thanks.

@eselmeister
Copy link
Contributor

Great, thanks for the hint. Could you share a CDF file for testing purposes?

@avasyanin
Copy link
Author

Yes, sure.

The file also contains some supporting information which is in an ancient CP1251 (Cyrillics), but actually it is not very important.

20240327-174018 [169.3] (1).cdf.zip

@eselmeister
Copy link
Contributor

@avasyanin Thanks for the file. It has been fixed and will be shipped with the next release, scheduled for Friday, 5th of April.

Screenshot from 2024-03-30 11-00-07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants