Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Conversation

NitaiBanik
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 1, 2021

CLA assistant check
All committers have signed the CLA.

@ratanparai ratanparai linked an issue May 1, 2021 that may be closed by this pull request
@NitaiBanik NitaiBanik requested a review from ratanparai May 1, 2021 17:35
@NitaiBanik NitaiBanik marked this pull request as ready for review May 2, 2021 06:48
@NitaiBanik NitaiBanik requested a review from mahedee as a code owner May 2, 2021 06:48
@ratanparai ratanparai linked an issue May 22, 2021 that may be closed by this pull request
@NitaiBanik NitaiBanik changed the title Certificate registration service initial implementation Certificate processing service initial implementation May 22, 2021
Nitai Chandra Banik added 3 commits May 22, 2021 22:31
This reverts commit 0679607.

# Conflicts:
#	src/Services/CertificateRegistration/CertificateRegistration.API/Startup.cs
@ratanparai
Copy link
Member

@NitaiBanik: can you please rename the service to CertificateProcessing service?

@NitaiBanik NitaiBanik closed this May 31, 2021
@NitaiBanik NitaiBanik reopened this May 31, 2021
Copy link
Member

@ratanparai ratanparai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I will create dockerfile for the service after you fix those

@ratanparai
Copy link
Member

@NitaiBanik: I tried to push Dockerfile modifications, but I do not have access to your branch. Can you please give me permission? Please check https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork for more info

@ratanparai ratanparai merged commit a0e76a7 into OpenCodeFoundation:master Jun 12, 2021
@ratanparai ratanparai added this to the v0.9.0 milestone Jun 12, 2021
@NitaiBanik NitaiBanik deleted the feature/nitai/CertificateRegistration_service_initial_implementation branch June 12, 2021 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants