This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Certificate processing service initial implementation #404
Merged
ratanparai
merged 16 commits into
OpenCodeFoundation:master
from
NitaiBanik:feature/nitai/CertificateRegistration_service_initial_implementation
Jun 12, 2021
Merged
Certificate processing service initial implementation #404
ratanparai
merged 16 commits into
OpenCodeFoundation:master
from
NitaiBanik:feature/nitai/CertificateRegistration_service_initial_implementation
Jun 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratanparai
suggested changes
May 1, 2021
src/Services/CertificateRegistration/CertificateRegistration.API/Startup.cs
Outdated
Show resolved
Hide resolved
src/Services/CertificateRegistration/CertificateRegistration.API/Startup.cs
Outdated
Show resolved
Hide resolved
…ice_initial_implementation
… environment dependency
ratanparai
suggested changes
May 22, 2021
src/Services/CertificateRegistration/CertificateRegistration.API/Startup.cs
Outdated
Show resolved
Hide resolved
NitaiBanik
changed the title
Certificate registration service initial implementation
Certificate processing service initial implementation
May 22, 2021
…ice_initial_implementation
This reverts commit 0679607. # Conflicts: # src/Services/CertificateRegistration/CertificateRegistration.API/Startup.cs
@NitaiBanik: can you please rename the service to |
ratanparai
suggested changes
Jun 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I will create dockerfile for the service after you fix those
src/Services/CertificateProcessing/CertificateProcessing.API/Startup.cs
Outdated
Show resolved
Hide resolved
...Services/CertificateProcessing/CertificateProcessing.API/Controllers/HelloWorldController.cs
Outdated
Show resolved
Hide resolved
@NitaiBanik: I tried to push Dockerfile modifications, but I do not have access to your branch. Can you please give me permission? Please check https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork for more info |
ratanparai
approved these changes
Jun 12, 2021
NitaiBanik
deleted the
feature/nitai/CertificateRegistration_service_initial_implementation
branch
June 12, 2021 16:31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.