This repository has been archived by the owner on Jul 11, 2018. It is now read-only.
Unexpected behaviour when using trusted proxies #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever one of the Metadata Repo Filters rejects an entity it's filtering this now can be logged by passing along a logger to the chain. Also did some minor cleanup in the classes, removing no longer used 'imports'.
jorissteyn
approved these changes
Jul 18, 2017
MKodde
changed the title
MKodde
added a commit
to OpenConext/OpenConext-engineblock
that referenced
this pull request
Jul 19, 2017
This implements the changes made in OpenConext-Attic/OpenConext-engineblock-metadata#14 that are required to add logging for handling the errors that can occur when dealing with trusted proxies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this Engineblock PR