This repository has been archived by the owner on Jul 11, 2018. It is now read-only.
Make sure WAYF visibility is reflected correctly #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Show unconnected IdP's in WAYF flag is enabled the unconnected should be displayed in the WAYF and not be filtered. In this commit the `findIdentityProviders` method for the DoctrineMetadataRepository makes sure it's results are visited by the Visitor implementation for IdPs.
MKodde
changed the title
thijskh
approved these changes
Jul 20, 2017
There was a problem hiding this comment.
It reeks a bit of code duplication that this change is necessary. It might be that OpenConext/OpenConext-engineblock#410 will eventually address that.
|
Although the change itself looks good, I am wondering about it solving the problem. In the EB source code I see findIdentityProviders() not used in a relevant code path? Or is it? |
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Show unconnected IdP's in WAYF flag is enabled the unconnected
should be displayed in the WAYF and not be filtered. In this commit the
findIdentityProvidersmethod for the DoctrineMetadataRepository makessure it's results are visited by the Visitor implementation for IdPs.
Main question is: does this change break other behaviour for the other methods that call and use this method. My gut feel tells me this change would only affect parts of the application that use the
IdentityProvider::$isEnabledInWayfproperty, so this change is quite safe..