This repository has been archived by the owner on Jul 11, 2018. It is now read-only.
Allow caching all database queries for the lifetime of a request #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorissteyn
force-pushed
the
feature/caching-metadata-repository
branch
from
80656f3
to
34b8517
Compare
This commit introduces a new metadata repository as an alternative to
the regular doctrine metadata repository. It wraps the regular
doctrine metadata repository but caches the result of each distinct
query for the request lifetime. This mechanism is safe to use for
EngineBlock since it doesn't write metadata, and we're not concerned
with metadata updates during an authentication request.
In test cases, using the caching wrapper reduces the number of queries
during a single authentication request from approximately 40 to 15.
In order to use this new repository in EngineBlock, replace the
following line in engineblock.ini:
metadataRepository.database.type = Doctrine
With:
metadataRepository.database.type = CachedDoctrine
jorissteyn
force-pushed
the
feature/caching-metadata-repository
branch
from
34b8517
to
4c11c95
Compare
MKodde
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new metadata repository as an alternative to
the regular doctrine metadata repository. It wraps the regular
doctrine metadata repository but caches the result of each distinct
query for the request lifetime. This mechanism is safe to use for
EngineBlock since it doesn't write metadata, and we're not concerned
with metadata updates during an authentication request.
In test cases, using the caching wrapper reduces the number of queries
during a single authentication request from approximately 40 to 15.
In order to use this new repository in EngineBlock, replace the
following line in engineblock.ini:
With: