Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename trustedProxy ini configuration option #311

Closed
thijskh opened this issue Jul 28, 2016 · 1 comment
Closed

Rename trustedProxy ini configuration option #311

thijskh opened this issue Jul 28, 2016 · 1 comment

Comments

@thijskh
Copy link
Member

thijskh commented Jul 28, 2016

The EB source code currently uses the words "trusted proxy" in two completely different meanings which is destined to be a source of confusion. It can mean a service provider metadata property that grants that service provider some special rights; and in engineblock.ini is used to specify the IP addresses of a reverse proxy EB may live behind.

The second meaning is probably easiest to change. I propose s/trustedProxyIps/reverseProxyIps/.
@thijskh
Copy link
Member Author

thijskh commented Sep 29, 2021

In the end probably not really worth it.

@thijskh thijskh closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thijskh