Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocoding in utils.py #14

Open
rleh opened this issue Apr 9, 2017 · 1 comment
Open

Geocoding in utils.py #14

rleh opened this issue Apr 9, 2017 · 1 comment

Comments

@rleh
Copy link
Contributor

rleh commented Apr 9, 2017

def get_city_by_coordinates(lon, lat)

in utils.py line 11 is not implemented, but a geocoding function is implemented in the geocoding module.
Is the function from utils.py used anywhere or can we remove it?
Otherwise we should be able to reuse the existing geocoding code somehow. Maybe by separating the request parsing and photon geocoding somehow?

@rleh
Copy link
Contributor Author

rleh commented Apr 9, 2017

The function is used here:

track_city = get_city_by_coordinates(json['data'][0]['lon'], json['data'][0]['lat'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant