Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS_ROOT not used in generated makefiles #1827

Closed
jwillemsen opened this issue Aug 5, 2020 · 6 comments
Closed

DDS_ROOT not used in generated makefiles #1827

jwillemsen opened this issue Aug 5, 2020 · 6 comments

Comments

@jwillemsen
Copy link
Member

When I moved locally a test to a different directory level I noticed that DDS_ROOT is not used in the generated GNU makefiles, a relative path is generated.

To reproduce generate the gnuace project files in examples/DCPS/ishapes and open the GNUmakefile.ishapes file. I would expect to find

LIBPATHS := . "$(ACE_ROOT)/lib" "$(DDS_ROOT)/lib" "$(QTDIR)/lib" "$(BOOST_ROOT)/lib"

but found

LIBPATHS := . "$(ACE_ROOT)/lib" "../../../lib" "$(QTDIR)/lib" "$(BOOST_ROOT)/lib"

Same for LIBCHECK, LDFLAGS

@jwillemsen
Copy link
Member Author

Just noticed that also the check for boost is generated twice in this file

ifneq ($(boost),1)
requires_disabled_macros += boost
endif
ifneq ($(boost),1)
requires_disabled_macros += boost
endif

@mitza-oci
Copy link
Member

I think this is by design. There are MPC options to change how it generates makefiles.

@jwillemsen
Copy link
Member Author

jwillemsen commented Aug 5, 2020

ACE_ROOT and TAO_ROOT are not expanded by default, any suggestions why ACE_ROOT/TAO_ROOT are not expanded but DDS_ROOT is? This makes it hard to work with multiple source trees

@mitza-oci
Copy link
Member

I think that's based on whether or not the project is in a child directory of that path. You can change the MPC options.

@jwillemsen
Copy link
Member Author

Which options @mitza-oci, I tried -use_env but that doesn't add DDS_ROOT

@mitza-oci
Copy link
Member

I'm not sure, it's been a long time since I've used those options. I don't think there's anything that we're doing in this repo to impact this, so maybe create an MPC issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants